Fix #854: change NoiseChannel.__str__ to use correct method#856
Merged
Fix #854: change NoiseChannel.__str__ to use correct method#856
Conversation
An inspection of the code of class `NoiseChannel` in `qsimcirq_tests/qsimcirq_tests.py` suggests that the most likely cause of error #854 is that the call to the `_ops` method should be instead to `_prob_op_pairs`, like this: ```python def __str__(self): return f"NoiseChannel({self._prob_op_pairs})" ```
dstrain115
approved these changes
Aug 15, 2025
pavoljuhas
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An inspection of the code of class
NoiseChannelinqsimcirq_tests/qsimcirq_tests.pysuggests that the call to the_opsmethod should be instead to_prob_op_pairs, like this:This works, and printing instances of the class do print something reasonable.